diff mbox

stb0899: Removed an extra byte sent at init on DiSEqC bus

Message ID 4C125DD5.6060604@anevia.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

Florent AUDEBERT June 11, 2010, 4:01 p.m. UTC 
Hi,

I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC
tool analyzer.

I removed the register from initialization table and all seem to go well
(at least for my KNC board).


Regards,


Signed-off-by: Florent Audebert <florent.audebert@anevia.com>
---
 drivers/media/dvb/dvb-usb/az6027.c       |    1 -
 drivers/media/dvb/mantis/mantis_vp1041.c |    1 -
 drivers/media/dvb/ttpci/budget-av.c      |    1 -
 drivers/media/dvb/ttpci/budget-ci.c      |    1 -
 4 files changed, 0 insertions(+), 4 deletions(-)

Comments

Florent AUDEBERT Oct. 19, 2010, 12:55 p.m. UTC | #1 
On 06/11/2010 06:01 PM, Florent AUDEBERT wrote:
> I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC
> tool analyzer.
> 
> I removed the register from initialization table and all seem to go well
> (at least for my KNC board).

Hi,

This old small patch had been marked superseded on patchwork[1].

Is there an non-obvious case when patches go superseded ? Perhaps I missed
something but it seems to me no other patch replaced it.


Regards,


[1] https://patchwork.kernel.org/patch/105621/
Mauro Carvalho Chehab Oct. 19, 2010, 4:05 p.m. UTC | #2 
Em 19-10-2010 10:55, Florent AUDEBERT escreveu:
> On 06/11/2010 06:01 PM, Florent AUDEBERT wrote:
>> I noticed a stray 0x00 at init on DiSEqC bus (KNC1 DVB-S2) with a DiSEqC
>> tool analyzer.
>>
>> I removed the register from initialization table and all seem to go well
>> (at least for my KNC board).
> 
> Hi,
> 
> This old small patch had been marked superseded on patchwork[1].
> 
> Is there an non-obvious case when patches go superseded ? Perhaps I missed
> something but it seems to me no other patch replaced it.

This is one of the bad things with patchwork: there's no "reason" field associated
to a status change, nor it marks when the status were changed.

A search on my linux-media box, showed that this patch were there, waiting for
Manu review, at the email I sent on Jul, 6 2010. The patch still applies, and
I didn't find any reply from Manu giving any feedback about it.

So, I'm re-tagging it as under review.

Manu, any comments about this patch (and the other remaining patches that we're
waiting fro your review) ?

> 
> 
> Regards,
> 
> 
> [1] https://patchwork.kernel.org/patch/105621/
> 

Cheers,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/media/dvb/dvb-usb/az6027.c b/drivers/media/dvb/dvb-usb/az6027.c
index 6681ac1..9710e7b 100644
--- a/drivers/media/dvb/dvb-usb/az6027.c
+++ b/drivers/media/dvb/dvb-usb/az6027.c
@@ -40,7 +40,6 @@  static const struct stb0899_s1_reg az6027_stb0899_s1_init_1[] = {
 	{ STB0899_DISRX_ST0     	, 0x04 },
 	{ STB0899_DISRX_ST1     	, 0x00 },
 	{ STB0899_DISPARITY     	, 0x00 },
-	{ STB0899_DISFIFO       	, 0x00 },
 	{ STB0899_DISSTATUS		, 0x20 },
 	{ STB0899_DISF22        	, 0x99 },
 	{ STB0899_DISF22RX      	, 0xa8 },
diff --git a/drivers/media/dvb/mantis/mantis_vp1041.c b/drivers/media/dvb/mantis/mantis_vp1041.c
index d1aa2bc..7bb1f28 100644
--- a/drivers/media/dvb/mantis/mantis_vp1041.c
+++ b/drivers/media/dvb/mantis/mantis_vp1041.c
@@ -51,7 +51,6 @@  static const struct stb0899_s1_reg vp1041_stb0899_s1_init_1[] = {
 	{ STB0899_DISRX_ST0     	, 0x04 },
 	{ STB0899_DISRX_ST1     	, 0x00 },
 	{ STB0899_DISPARITY     	, 0x00 },
-	{ STB0899_DISFIFO       	, 0x00 },
 	{ STB0899_DISSTATUS		, 0x20 },
 	{ STB0899_DISF22        	, 0x99 },
 	{ STB0899_DISF22RX      	, 0xa8 },
diff --git a/drivers/media/dvb/ttpci/budget-av.c b/drivers/media/dvb/ttpci/budget-av.c
index 983672a..b697af4 100644
--- a/drivers/media/dvb/ttpci/budget-av.c
+++ b/drivers/media/dvb/ttpci/budget-av.c
@@ -896,7 +896,6 @@  static const struct stb0899_s1_reg knc1_stb0899_s1_init_1[] = {
 	{ STB0899_DISRX_ST0		, 0x04 },
 	{ STB0899_DISRX_ST1		, 0x00 },
 	{ STB0899_DISPARITY		, 0x00 },
-	{ STB0899_DISFIFO		, 0x00 },
 	{ STB0899_DISSTATUS		, 0x20 },
 	{ STB0899_DISF22		, 0x8c },
 	{ STB0899_DISF22RX		, 0x9a },
diff --git a/drivers/media/dvb/ttpci/budget-ci.c b/drivers/media/dvb/ttpci/budget-ci.c
index 13ac9e3..da5a72c 100644
--- a/drivers/media/dvb/ttpci/budget-ci.c
+++ b/drivers/media/dvb/ttpci/budget-ci.c
@@ -1046,7 +1046,6 @@  static const struct stb0899_s1_reg tt3200_stb0899_s1_init_1[] = {
 	{ STB0899_DISRX_ST0     	, 0x04 },
 	{ STB0899_DISRX_ST1     	, 0x00 },
 	{ STB0899_DISPARITY     	, 0x00 },
-	{ STB0899_DISFIFO       	, 0x00 },
 	{ STB0899_DISSTATUS		, 0x20 },
 	{ STB0899_DISF22        	, 0x8c },
 	{ STB0899_DISF22RX      	, 0x9a },