[1/3,media] s5p-mfc: use mfc_err instead of printk

Message ID 1356689908-6866-1-git-send-email-sachin.kamat@linaro.org (mailing list archive)
State Superseded, archived
Headers

Commit Message

Sachin Kamat Dec. 28, 2012, 10:18 a.m. UTC
  Use mfc_err for consistency. Also silences checkpatch warning.

Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
 drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)
  

Comments

Kamil Debski Jan. 2, 2013, 6:30 p.m. UTC | #1
Hi Sachin,

Thank you for your patch.

Best wishes,
  
Sylwester Nawrocki Jan. 7, 2013, 10:02 a.m. UTC | #2
Hi Sachin,

On 01/07/2013 05:09 AM, Sachin Kamat wrote:
> Hi Sylwester,
> 
> On 3 January 2013 00:00, Kamil Debski <k.debski@samsung.com> wrote:
>> Hi Sachin,
>>
>> Thank you for your patch.
>>
>> Best wishes,
>> --
>> Kamil Debski
>> Linux Platform Group
>> Samsung Poland R&D Center
>>
>>> From: linux-media-owner@vger.kernel.org [mailto:linux-media-
>>> owner@vger.kernel.org] On Behalf Of Sachin Kamat
>>> Sent: Friday, December 28, 2012 11:18 AM
>>> To: linux-media@vger.kernel.org
>>> Cc: k.debski@samsung.com; s.nawrocki@samsung.com;
>>> sylvester.nawrocki@gmail.com; sachin.kamat@linaro.org;
>>> patches@linaro.org
>>> Subject: [PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk
>>>
>>> Use mfc_err for consistency. Also silences checkpatch warning.
>>>
>>
>> Acked-by: Kamil Debski <k.debski@samsung.com>
>>
>>> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
>>> ---
> 
> Probably you missed to apply this patch to your tree.

Hmm, not really, I intended it for a second v3.9 pull request.
However I checked it yesterday and it doesn't apply any more.
Since one of Kamil's patches includes same change.

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
  

Patch

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
index bf7d010..bb99d3d 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c
@@ -187,8 +187,7 @@  int s5p_mfc_alloc_codec_buffers_v5(struct s5p_mfc_ctx *ctx)
 		dev->alloc_ctx[MFC_BANK1_ALLOC_CTX], ctx->bank1_size);
 		if (IS_ERR(ctx->bank1_buf)) {
 			ctx->bank1_buf = NULL;
-			printk(KERN_ERR
-			       "Buf alloc for decoding failed (port A)\n");
+			mfc_err("Buf alloc for decoding failed (port A)\n");
 			return -ENOMEM;
 		}
 		ctx->bank1_phys = s5p_mfc_mem_cookie(