Message ID | 1353048646-10935-6-git-send-email-tushar.behera@linaro.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Guennadi Liakhovetski |
Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1TZFtm-0003Ja-RM for patchwork@linuxtv.org; Fri, 16 Nov 2012 07:59:34 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for <patchwork@linuxtv.org> id 1TZFtm-0007Nb-AO; Fri, 16 Nov 2012 07:59:34 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751504Ab2KPG5V (ORCPT <rfc822;patchwork@linuxtv.org>); Fri, 16 Nov 2012 01:57:21 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:55740 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450Ab2KPG5N (ORCPT <rfc822;linux-media@vger.kernel.org>); Fri, 16 Nov 2012 01:57:13 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so1734368pbc.19 for <linux-media@vger.kernel.org>; Thu, 15 Nov 2012 22:57:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=yAf1cjl9fbYvOYv76XSmGQ9rzRPAb+ZhgOID8AouvIA=; b=ItGWOOikf26rTgQWw+30E3b0OqUWlRBQtxxYBgaZ2TyUOhqoXD1sj18Z73SZ/GWHDB GLXxBapXVII7UxY/CaA67KTJywq3NaDDsgWs4MkxOxdFTnuoBeTh4CrE0pGekxM1l/yK Vm6vtfbzNjLWHjNDtV9JgEsth2uaxx88VfrPyFr+uV+2IhftqpDcmfqqP8k9seDfhMae O8L4wVUci2e2VPn8ZuBJGYBU6G+LXZmRHlXlUG8NJgSZO6w642WkiT6Hb6U08aL2NO2O UVGmzXHGrVIxzPKlZDuROrG2TxC0q1W3mg/wWQ5imDCy8uw6KQSFLnxVJqTKOd+HErwE Dgng== Received: by 10.68.243.10 with SMTP id wu10mr12274722pbc.85.1353049033521; Thu, 15 Nov 2012 22:57:13 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id mz10sm753915pbc.37.2012.11.15.22.57.10 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 22:57:12 -0800 (PST) From: Tushar Behera <tushar.behera@linaro.org> To: linux-kernel@vger.kernel.org Cc: patches@linaro.org, Mauro Carvalho Chehab <mchehab@infradead.org>, linux-media@vger.kernel.org Subject: [PATCH 05/14] [media] atmel-isi: Update error check for unsigned variables Date: Fri, 16 Nov 2012 12:20:37 +0530 Message-Id: <1353048646-10935-6-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> References: <1353048646-10935-1-git-send-email-tushar.behera@linaro.org> X-Gm-Message-State: ALoCoQlkZ+DuwE1zaJOLpJ38yfdF1vfo7zJ96l1LzL79yQAMFZ89MCgd9kiNWXcvHPkxHIeyHEuW Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.16.64818 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' |
Commit Message
Tushar Behera
Nov. 16, 2012, 6:50 a.m. UTC
Checking '< 0' for unsigned variables always returns false. For error
codes, use IS_ERR_VALUE() instead.
CC: Mauro Carvalho Chehab <mchehab@infradead.org>
CC: linux-media@vger.kernel.org
Signed-off-by: Tushar Behera <tushar.behera@linaro.org>
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
Comments
On Fri, 16 Nov 2012, Tushar Behera wrote: > Checking '< 0' for unsigned variables always returns false. For error > codes, use IS_ERR_VALUE() instead. Wouldn't just changing "irq" type to "int" also work? I think that would be a more straight-forward solution. If however there are strong arguments against that, I'm fine with this fix too. Thanks Guennadi > > CC: Mauro Carvalho Chehab <mchehab@infradead.org> > CC: linux-media@vger.kernel.org > Signed-off-by: Tushar Behera <tushar.behera@linaro.org> > --- > drivers/media/platform/soc_camera/atmel-isi.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c > index 6274a91..5bd65df 100644 > --- a/drivers/media/platform/soc_camera/atmel-isi.c > +++ b/drivers/media/platform/soc_camera/atmel-isi.c > @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct platform_device *pdev) > isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > + if (IS_ERR_VALUE(irq)) { > ret = irq; > goto err_req_irq; > } > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/ -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 11/18/2012 04:46 AM, Guennadi Liakhovetski wrote: > On Fri, 16 Nov 2012, Tushar Behera wrote: > >> Checking '< 0' for unsigned variables always returns false. For error >> codes, use IS_ERR_VALUE() instead. > > Wouldn't just changing "irq" type to "int" also work? I think that would > be a more straight-forward solution. If however there are strong arguments > against that, I'm fine with this fix too. > By changing irq to signed variable, we would get compilation warning in subsequent line (request_irq). > Thanks > Guennadi > >> >> CC: Mauro Carvalho Chehab <mchehab@infradead.org> >> CC: linux-media@vger.kernel.org >> Signed-off-by: Tushar Behera <tushar.behera@linaro.org> >> --- >> drivers/media/platform/soc_camera/atmel-isi.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c >> index 6274a91..5bd65df 100644 >> --- a/drivers/media/platform/soc_camera/atmel-isi.c >> +++ b/drivers/media/platform/soc_camera/atmel-isi.c >> @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct platform_device *pdev) >> isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS); >> >> irq = platform_get_irq(pdev, 0); >> - if (irq < 0) { >> + if (IS_ERR_VALUE(irq)) { >> ret = irq; >> goto err_req_irq; >> } >> -- >> 1.7.4.1 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > > --- > Guennadi Liakhovetski, Ph.D. > Freelance Open-Source Software Developer > http://www.open-technology.de/ >
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c index 6274a91..5bd65df 100644 --- a/drivers/media/platform/soc_camera/atmel-isi.c +++ b/drivers/media/platform/soc_camera/atmel-isi.c @@ -1020,7 +1020,7 @@ static int __devinit atmel_isi_probe(struct platform_device *pdev) isi_writel(isi, ISI_CTRL, ISI_CTRL_DIS); irq = platform_get_irq(pdev, 0); - if (irq < 0) { + if (IS_ERR_VALUE(irq)) { ret = irq; goto err_req_irq; }