mbox

[GIT,PULL,FOR,3.7] Samsung media drivers fixes

Message ID 5089624D.2000903@samsung.com (mailing list archive)
State Accepted, archived
Headers

Pull-request

git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7

Message

Sylwester Nawrocki Oct. 25, 2012, 4:01 p.m. UTC 
Hi Mauro,

please pull following fixes for v3.7-rc.

The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:

  [media] m5mols: Add missing #include <linux/sizes.h> (2012-10-10 08:17:16 -0300)

are available in the git repository at:

  git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7

for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:

  s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)

----------------------------------------------------------------
Jesper Juhl (1):
      s5p-tv: don't include linux/version.h in mixer_video.c

Sachin Kamat (5):
      s5p-mfc: Fix compilation warning
      exynos-gsc: Fix compilation warning
      s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
      s5p-fimc: Make 'fimc_pipeline_s_stream' function static
      s5p-fimc: Fix potential NULL pointer dereference

Shaik Ameer Basha (3):
      exynos-gsc: change driver compatible string
      exynos-gsc: fix variable type in gsc_m2m_device_run()
      s5p-fimc: fix variable type in fimc_device_run()

Sylwester Nawrocki (4):
      s5p-fimc: Don't ignore return value of vb2_queue_init()
      s5p-csis: Select S5P_SETUP_MIPIPHY
      s5p-fimc: Add missing new line character
      s5p-fimc: Fix platform entities registration

 drivers/media/platform/exynos-gsc/gsc-core.c   |    8 +++--
 drivers/media/platform/exynos-gsc/gsc-m2m.c    |    2 +-
 drivers/media/platform/s5p-fimc/Kconfig        |    1 +
 drivers/media/platform/s5p-fimc/fimc-capture.c |    4 ++-
 drivers/media/platform/s5p-fimc/fimc-lite.c    |    4 ++-
 drivers/media/platform/s5p-fimc/fimc-m2m.c     |    2 +-
 drivers/media/platform/s5p-fimc/fimc-mdevice.c |   45 ++++++++++++------------
 drivers/media/platform/s5p-mfc/s5p_mfc_enc.c   |    2 +-
 drivers/media/platform/s5p-mfc/s5p_mfc_pm.c    |    2 +-
 drivers/media/platform/s5p-tv/mixer_video.c    |    1 -
 10 files changed, 38 insertions(+), 33 deletions(-)


Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Mauro Carvalho Chehab Oct. 25, 2012, 4:46 p.m. UTC | #1 
Em Thu, 25 Oct 2012 18:01:17 +0200
Sylwester Nawrocki <s.nawrocki@samsung.com> escreveu:

> Hi Mauro,
> 
> please pull following fixes for v3.7-rc.
> 
> The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
> 
>   [media] m5mols: Add missing #include <linux/sizes.h> (2012-10-10 08:17:16 -0300)
> 
> are available in the git repository at:
> 
>   git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
> 
> for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
> 
>   s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
> 
> ----------------------------------------------------------------
> Jesper Juhl (1):
>       s5p-tv: don't include linux/version.h in mixer_video.c
> 
> Sachin Kamat (5):
>       s5p-mfc: Fix compilation warning
>       exynos-gsc: Fix compilation warning
>       s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
>       s5p-fimc: Make 'fimc_pipeline_s_stream' function static
>       s5p-fimc: Fix potential NULL pointer dereference
> 
> Shaik Ameer Basha (3):
>       exynos-gsc: change driver compatible string
>       exynos-gsc: fix variable type in gsc_m2m_device_run()
>       s5p-fimc: fix variable type in fimc_device_run()
> 
> Sylwester Nawrocki (4):
>       s5p-fimc: Don't ignore return value of vb2_queue_init()
>       s5p-csis: Select S5P_SETUP_MIPIPHY
>       s5p-fimc: Add missing new line character
>       s5p-fimc: Fix platform entities registration


Only a few of the above seems to be material for -rc:
	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
	s5p-fimc: Fix platform entities registration (60 seconds ago)
	s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
	s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)

The other ones are warnings/sparse warnings and cleanups. I'll
be applying only the 4 above patches for 3.7, adding the other
ones for 3.8.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sylwester Nawrocki Oct. 25, 2012, 6:59 p.m. UTC | #2 
On 10/25/2012 06:46 PM, Mauro Carvalho Chehab wrote:
> Em Thu, 25 Oct 2012 18:01:17 +0200
> Sylwester Nawrocki<s.nawrocki@samsung.com>  escreveu:
> 
>> Hi Mauro,
>>
>> please pull following fixes for v3.7-rc.
>>
>> The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
>>
>>    [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
>>
>> are available in the git repository at:
>>
>>    git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
>>
>> for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
>>
>>    s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
>>
>> ----------------------------------------------------------------
>> Jesper Juhl (1):
>>        s5p-tv: don't include linux/version.h in mixer_video.c
>>
>> Sachin Kamat (5):
>>        s5p-mfc: Fix compilation warning
>>        exynos-gsc: Fix compilation warning
>>        s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
>>        s5p-fimc: Make 'fimc_pipeline_s_stream' function static
>>        s5p-fimc: Fix potential NULL pointer dereference
>>
>> Shaik Ameer Basha (3):
>>        exynos-gsc: change driver compatible string
>>        exynos-gsc: fix variable type in gsc_m2m_device_run()
>>        s5p-fimc: fix variable type in fimc_device_run()
>>
>> Sylwester Nawrocki (4):
>>        s5p-fimc: Don't ignore return value of vb2_queue_init()
>>        s5p-csis: Select S5P_SETUP_MIPIPHY
>>        s5p-fimc: Add missing new line character
>>        s5p-fimc: Fix platform entities registration
> 
> 
> Only a few of the above seems to be material for -rc:
> 	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
> 	s5p-fimc: Fix platform entities registration (60 seconds ago)
> 	s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
> 	s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)
> 
> The other ones are warnings/sparse warnings and cleanups. I'll
> be applying only the 4 above patches for 3.7, adding the other
> ones for 3.8.

Sorry for mixing them up. Except those 4, "exynos-gsc: change driver 
compatible string" really needs to go in 3.7. Bootloaders will be
supplying an FDT node for this device with compatible string
"samsung,exynos5-gsc", not "samsung,exynos5250-gsc". In case this patch 
is applied only starting from 3.8, kernels 3.7, where the GScaler driver 
was first added, will have broken support for this device. Hence this 
patch should be considered as a real bug fix.

For those embedded systems it might not be a big deal, since it rarely
happens pure mainline kernel is used for production. But in principle
it's better to apply that patch, to avoid mess where different kernels
require different compatible string. This would mean an ABI breakage.

--

Thanks,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Sylwester Nawrocki Oct. 26, 2012, 10:15 a.m. UTC | #3 
On 10/25/2012 08:59 PM, Sylwester Nawrocki wrote:
> On 10/25/2012 06:46 PM, Mauro Carvalho Chehab wrote:
>> Em Thu, 25 Oct 2012 18:01:17 +0200
>> Sylwester Nawrocki<s.nawrocki@samsung.com>  escreveu:
>>
>>> Hi Mauro,
>>>
>>> please pull following fixes for v3.7-rc.
>>>
>>> The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
>>>
>>>    [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
>>>
>>> are available in the git repository at:
>>>
>>>    git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
>>>
>>> for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
>>>
>>>    s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
>>>
>>> ----------------------------------------------------------------
>>> Jesper Juhl (1):
>>>        s5p-tv: don't include linux/version.h in mixer_video.c
>>>
>>> Sachin Kamat (5):
>>>        s5p-mfc: Fix compilation warning
>>>        exynos-gsc: Fix compilation warning
>>>        s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
>>>        s5p-fimc: Make 'fimc_pipeline_s_stream' function static
>>>        s5p-fimc: Fix potential NULL pointer dereference
>>>
>>> Shaik Ameer Basha (3):
>>>        exynos-gsc: change driver compatible string
>>>        exynos-gsc: fix variable type in gsc_m2m_device_run()
>>>        s5p-fimc: fix variable type in fimc_device_run()
>>>
>>> Sylwester Nawrocki (4):
>>>        s5p-fimc: Don't ignore return value of vb2_queue_init()
>>>        s5p-csis: Select S5P_SETUP_MIPIPHY
>>>        s5p-fimc: Add missing new line character
>>>        s5p-fimc: Fix platform entities registration
>>
>>
>> Only a few of the above seems to be material for -rc:
>> 	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
>> 	s5p-fimc: Fix platform entities registration (60 seconds ago)
>> 	s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
>> 	s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)
>>
>> The other ones are warnings/sparse warnings and cleanups. I'll
>> be applying only the 4 above patches for 3.7, adding the other
>> ones for 3.8.

I've noticed "s5p-fimc: Fix platform entities registration" will cause
a race condition. Can you please drop entirely these two patches from
the 3.7 queue:

 	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
 	s5p-fimc: Fix platform entities registration (60 seconds ago)
?

Alternatively I can send a subsequent follow up patch.

> Sorry for mixing them up. Except those 4, "exynos-gsc: change driver 
> compatible string" really needs to go in 3.7. Bootloaders will be
> supplying an FDT node for this device with compatible string
> "samsung,exynos5-gsc", not "samsung,exynos5250-gsc". In case this patch 
> is applied only starting from 3.8, kernels 3.7, where the GScaler driver 
> was first added, will have broken support for this device. Hence this 
> patch should be considered as a real bug fix.
> 
> For those embedded systems it might not be a big deal, since it rarely
> happens pure mainline kernel is used for production. But in principle
> it's better to apply that patch, to avoid mess where different kernels
> require different compatible string. This would mean an ABI breakage.


--
Regards,
Sylwester
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab Oct. 27, 2012, 10:19 a.m. UTC | #4 
Em Thu, 25 Oct 2012 20:59:09 +0200
Sylwester Nawrocki <sylvester.nawrocki@gmail.com> escreveu:

> On 10/25/2012 06:46 PM, Mauro Carvalho Chehab wrote:
> > Em Thu, 25 Oct 2012 18:01:17 +0200
> > Sylwester Nawrocki<s.nawrocki@samsung.com>  escreveu:
> > 
> >> Hi Mauro,
> >>
> >> please pull following fixes for v3.7-rc.
> >>
> >> The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
> >>
> >>    [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
> >>
> >> are available in the git repository at:
> >>
> >>    git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
> >>
> >> for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
> >>
> >>    s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
> >>
> >> ----------------------------------------------------------------
> >> Jesper Juhl (1):
> >>        s5p-tv: don't include linux/version.h in mixer_video.c
> >>
> >> Sachin Kamat (5):
> >>        s5p-mfc: Fix compilation warning
> >>        exynos-gsc: Fix compilation warning
> >>        s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
> >>        s5p-fimc: Make 'fimc_pipeline_s_stream' function static
> >>        s5p-fimc: Fix potential NULL pointer dereference
> >>
> >> Shaik Ameer Basha (3):
> >>        exynos-gsc: change driver compatible string
> >>        exynos-gsc: fix variable type in gsc_m2m_device_run()
> >>        s5p-fimc: fix variable type in fimc_device_run()
> >>
> >> Sylwester Nawrocki (4):
> >>        s5p-fimc: Don't ignore return value of vb2_queue_init()
> >>        s5p-csis: Select S5P_SETUP_MIPIPHY
> >>        s5p-fimc: Add missing new line character
> >>        s5p-fimc: Fix platform entities registration
> > 
> > 
> > Only a few of the above seems to be material for -rc:
> > 	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
> > 	s5p-fimc: Fix platform entities registration (60 seconds ago)
> > 	s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
> > 	s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)
> > 
> > The other ones are warnings/sparse warnings and cleanups. I'll
> > be applying only the 4 above patches for 3.7, adding the other
> > ones for 3.8.
> 
> Sorry for mixing them up. Except those 4, "exynos-gsc: change driver 
> compatible string" really needs to go in 3.7. Bootloaders will be
> supplying an FDT node for this device with compatible string
> "samsung,exynos5-gsc", not "samsung,exynos5250-gsc". In case this patch 
> is applied only starting from 3.8, kernels 3.7, where the GScaler driver 
> was first added, will have broken support for this device. Hence this 
> patch should be considered as a real bug fix.
> 
> For those embedded systems it might not be a big deal, since it rarely
> happens pure mainline kernel is used for production. But in principle
> it's better to apply that patch, to avoid mess where different kernels
> require different compatible string. This would mean an ABI breakage.

Ok, added it at my 3.7 sandbox.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Mauro Carvalho Chehab Oct. 27, 2012, 10:19 a.m. UTC | #5 
Em Fri, 26 Oct 2012 12:15:41 +0200
Sylwester Nawrocki <s.nawrocki@samsung.com> escreveu:

> On 10/25/2012 08:59 PM, Sylwester Nawrocki wrote:
> > On 10/25/2012 06:46 PM, Mauro Carvalho Chehab wrote:
> >> Em Thu, 25 Oct 2012 18:01:17 +0200
> >> Sylwester Nawrocki<s.nawrocki@samsung.com>  escreveu:
> >>
> >>> Hi Mauro,
> >>>
> >>> please pull following fixes for v3.7-rc.
> >>>
> >>> The following changes since commit 1fdead8ad31d3aa833bc37739273fcde89ace93c:
> >>>
> >>>    [media] m5mols: Add missing #include<linux/sizes.h>  (2012-10-10 08:17:16 -0300)
> >>>
> >>> are available in the git repository at:
> >>>
> >>>    git://git.infradead.org/users/kmpark/linux-samsung v4l_fixes_for_v3.7
> >>>
> >>> for you to fetch changes up to df79eb9e19331685e509d62112972b3c35569f0b:
> >>>
> >>>    s5p-fimc: Fix potential NULL pointer dereference (2012-10-25 16:08:12 +0200)
> >>>
> >>> ----------------------------------------------------------------
> >>> Jesper Juhl (1):
> >>>        s5p-tv: don't include linux/version.h in mixer_video.c
> >>>
> >>> Sachin Kamat (5):
> >>>        s5p-mfc: Fix compilation warning
> >>>        exynos-gsc: Fix compilation warning
> >>>        s5p-mfc: Make 'clk_ref' static in s5p_mfc_pm.c
> >>>        s5p-fimc: Make 'fimc_pipeline_s_stream' function static
> >>>        s5p-fimc: Fix potential NULL pointer dereference
> >>>
> >>> Shaik Ameer Basha (3):
> >>>        exynos-gsc: change driver compatible string
> >>>        exynos-gsc: fix variable type in gsc_m2m_device_run()
> >>>        s5p-fimc: fix variable type in fimc_device_run()
> >>>
> >>> Sylwester Nawrocki (4):
> >>>        s5p-fimc: Don't ignore return value of vb2_queue_init()
> >>>        s5p-csis: Select S5P_SETUP_MIPIPHY
> >>>        s5p-fimc: Add missing new line character
> >>>        s5p-fimc: Fix platform entities registration
> >>
> >>
> >> Only a few of the above seems to be material for -rc:
> >> 	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
> >> 	s5p-fimc: Fix platform entities registration (60 seconds ago)
> >> 	s5p-csis: Select S5P_SETUP_MIPIPHY (60 seconds ago)
> >> 	s5p-fimc: Don't ignore return value of vb2_queue_init() (61 seconds ago)
> >>
> >> The other ones are warnings/sparse warnings and cleanups. I'll
> >> be applying only the 4 above patches for 3.7, adding the other
> >> ones for 3.8.
> 
> I've noticed "s5p-fimc: Fix platform entities registration" will cause
> a race condition. Can you please drop entirely these two patches from
> the 3.7 queue:
> 
>  	s5p-fimc: Fix potential NULL pointer dereference (59 seconds ago)
>  	s5p-fimc: Fix platform entities registration (60 seconds ago)
> ?
> 
> Alternatively I can send a subsequent follow up patch.

As I already applied pinchartl patches on my 3.7 sandbox, I prefer if you
could send it as a follow up patch.

Regards,
Mauro
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html