| Message ID | 1343950313.11458.10.camel@router7789 (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers |
Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from <linux-media-owner@vger.kernel.org>) id 1Sx4so-0008Mp-DZ for patchwork@linuxtv.org; Fri, 03 Aug 2012 01:32:46 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for <patchwork@linuxtv.org> id 1Sx4sm-0007Q9-FL; Fri, 03 Aug 2012 01:32:45 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754009Ab2HBXcH (ORCPT <rfc822;patchwork@linuxtv.org>); Thu, 2 Aug 2012 19:32:07 -0400 Received: from mail-we0-f174.google.com ([74.125.82.174]:33459 "EHLO mail-we0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753639Ab2HBXcD (ORCPT <rfc822; linux-media@vger.kernel.org>); Thu, 2 Aug 2012 19:32:03 -0400 Received: by weyx8 with SMTP id x8so53303wey.19 for <linux-media@vger.kernel.org>; Thu, 02 Aug 2012 16:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:in-reply-to:references :content-type:x-mailer:content-transfer-encoding:mime-version; bh=VRJNW6DHOHgXbgN5KnGgf8fO8lc0YUhbYHXR42oiz7Q=; b=h+uzPjO2k11Op44ZliG5MzS3c/UOl6n/chN0gUX/GfjfgHu7XCHkPNlzg+keCUbomC HbHaFtHBkqOlSQOAZcqA0Gr7tLPlcB1x50puU1xCMY4g/VLFY1Z5Peu0+VFXCGhpP7oz SFH9e2GCNRjQq4POzmB1dyvDT1pLGtWil6QxKtYk7lxiZqCxugSEqbOJuO3NXCQoWMdJ YRhUU/oFI1IfAfmSuYGGpCwKwYQMwR4lFItxqb5fT3xpwrqEA2VKcrSSb+DH+OKaAtV9 bqWzP9rszq8EsisZ8oxAejUGtGKexHv1j2lSOsUDrANp53xu9XLFLaoKaR9aRPGhbHDP NOxA== Received: by 10.180.81.38 with SMTP id w6mr8477072wix.10.1343950322407; Thu, 02 Aug 2012 16:32:02 -0700 (PDT) Received: from [94.197.238.252] (94.197.238.252.threembb.co.uk. [94.197.238.252]) by mx.google.com with ESMTPS id t7sm21069826wix.6.2012.08.02.16.31.59 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Aug 2012 16:32:00 -0700 (PDT) Message-ID: <1343950313.11458.10.camel@router7789> Subject: [PATCH] [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000) From: Malcolm Priestley <tvboxspy@gmail.com> To: Antti Palosaari <crope@iki.fi> Cc: linux-media <linux-media@vger.kernel.org> Date: Fri, 03 Aug 2012 00:31:53 +0100 In-Reply-To: <501AE90E.2020201@iki.fi> References: <501AE90E.2020201@iki.fi> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.2.3-0ubuntu6 Content-Transfer-Encoding: 8bit Mime-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.8.2.231817 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, HTML_00_01 0.05, HTML_00_10 0.05, MIME_LOWER_CASE 0.05, BODY_SIZE_10000_PLUS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, INVALID_MSGID_NO_FQDN 0, __ANY_URI 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BADTHINGS 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __HIGHBITS 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_PATH 0, __URI_NO_WWW 0, __URI_NS ' |
Commit Message
Malcolm Priestley
Aug. 2, 2012, 11:31 p.m. UTC
On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: > Moi Malcolm, > Any idea why this seems to crash Kernel just when device is plugged? > Hi Antti Yes, there missing error handling when no firmware file found. It seems that this is more of a problem with udev-182+. However, so far udev-182 is only a problem on first ever plug. Regards Malcolm Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> --- drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On 08/03/2012 01:31 AM, Malcolm Priestley wrote: > On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: >> Moi Malcolm, >> Any idea why this seems to crash Kernel just when device is plugged? >> > Hi Antti > > Yes, there missing error handling when no firmware file found. > > It seems that this is more of a problem with udev-182+. > > However, so far udev-182 is only a problem on first ever plug. > > Regards > > > Malcolm > > > Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> > --- > drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c > index 25d1031..26ba5bc 100644 > --- a/drivers/media/dvb/dvb-usb/lmedm04.c > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c > @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) > fw_lme = fw_c_rs2000; > ret = request_firmware(&fw, fw_lme, &udev->dev); > dvb_usb_lme2510_firmware = TUNER_RS2000; > + if (ret == 0) > + break; > + info("FRM No Firmware Found - please install"); > + cold_fw = 0; > break; > default: > fw_lme = fw_c_s7395; > Do we need fw blob anymore!? http://www.spinics.net/lists/hotplug/msg05257.html … "Firmware is loaded natively by udev now, the external 'firmware' binary is no longer used." … Cheers, poma -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 08/03/2012 02:31 AM, Malcolm Priestley wrote: > On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: >> Moi Malcolm, >> Any idea why this seems to crash Kernel just when device is plugged? >> > Hi Antti > > Yes, there missing error handling when no firmware file found. > > It seems that this is more of a problem with udev-182+. > > However, so far udev-182 is only a problem on first ever plug. > > Regards > > > Malcolm Aug 6 20:56:34 localhost kernel: [19094.248540] LME2510(C): Firmware Status: 6 (44) Aug 6 20:56:34 localhost kernel: [19094.251541] LME2510(C): FRM No Firmware Found - please install Aug 6 20:56:34 localhost kernel: [19094.251559] usbcore: registered new interface driver LME2510C_DVB-S It is good to print needed fw name. I found it from the documentation, Documentation/dvb/lmedm04.txt. Could you drop me that firmware privately as I don't wish to install Windows drivers in order to extract it. Tested-by: Antti Palosaari <crope@iki.fi> > Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> > --- > drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c > index 25d1031..26ba5bc 100644 > --- a/drivers/media/dvb/dvb-usb/lmedm04.c > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c > @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) > fw_lme = fw_c_rs2000; > ret = request_firmware(&fw, fw_lme, &udev->dev); > dvb_usb_lme2510_firmware = TUNER_RS2000; > + if (ret == 0) > + break; > + info("FRM No Firmware Found - please install"); > + cold_fw = 0; > break; > default: > fw_lme = fw_c_s7395; > regards Antti
On Mon, 2012-08-06 at 21:46 +0300, Antti Palosaari wrote: > On 08/03/2012 02:31 AM, Malcolm Priestley wrote: > > On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: > >> Moi Malcolm, > >> Any idea why this seems to crash Kernel just when device is plugged? > >> > > Hi Antti > > > > Yes, there missing error handling when no firmware file found. > > > > It seems that this is more of a problem with udev-182+. > > > > However, so far udev-182 is only a problem on first ever plug. > > > > Regards > > > > > > Malcolm > > > Aug 6 20:56:34 localhost kernel: [19094.248540] LME2510(C): Firmware > Status: 6 (44) > Aug 6 20:56:34 localhost kernel: [19094.251541] LME2510(C): FRM No > Firmware Found - please install > Aug 6 20:56:34 localhost kernel: [19094.251559] usbcore: registered new > interface driver LME2510C_DVB-S > > It is good to print needed fw name. I found it from the documentation, > Documentation/dvb/lmedm04.txt. Hi Antti, Yes, this is a good idea to print the firmware it finds and then selects. > > Could you drop me that firmware privately as I don't wish to install > Windows drivers in order to extract it. > It would be interesting to see if your firmware is newer, my two boxes are over a year old. I as sure the firmware has a bug. Regards Malcolm > > Tested-by: Antti Palosaari <crope@iki.fi> > > > Signed-off-by: Malcolm Priestley <tvboxspy@gmail.com> > > --- > > drivers/media/dvb/dvb-usb/lmedm04.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c > > index 25d1031..26ba5bc 100644 > > --- a/drivers/media/dvb/dvb-usb/lmedm04.c > > +++ b/drivers/media/dvb/dvb-usb/lmedm04.c > > @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) > > fw_lme = fw_c_rs2000; > > ret = request_firmware(&fw, fw_lme, &udev->dev); > > dvb_usb_lme2510_firmware = TUNER_RS2000; > > + if (ret == 0) > > + break; > > + info("FRM No Firmware Found - please install"); > > + cold_fw = 0; > > break; > > default: > > fw_lme = fw_c_s7395; > > > > > regards > Antti > > > -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/media/dvb/dvb-usb/lmedm04.c b/drivers/media/dvb/dvb-usb/lmedm04.c index 25d1031..26ba5bc 100644 --- a/drivers/media/dvb/dvb-usb/lmedm04.c +++ b/drivers/media/dvb/dvb-usb/lmedm04.c @@ -878,6 +878,10 @@ static int lme_firmware_switch(struct usb_device *udev, int cold) fw_lme = fw_c_rs2000; ret = request_firmware(&fw, fw_lme, &udev->dev); dvb_usb_lme2510_firmware = TUNER_RS2000; + if (ret == 0) + break; + info("FRM No Firmware Found - please install"); + cold_fw = 0; break; default: fw_lme = fw_c_s7395;